Use correct images for alpha and dev builds #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ife6cf86f2fea1465cee3ed1815d1fc4af0e6583f
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/failing-test
k8s-ci-robot
added
the
approved
|
the change looks good to me. Will let @jingxu97 lgtm it |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind failing-test
See failing migration tests, eg https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-gcp-compute-persistent-disk-csi-driver-latest-k8s-master-migration/1456750077849636864.
The migration tests use the dev overlay, which get images from alpha.
The alpha image overlay included some images apparently targeted at windows. However, metadata name doesn't mean anything, and the transformers changed the images on all versions. The csi driver image ends up being a no-op, because the tag is set to the latest build, but the node-driver-registrar change is effective. When the registrar was updated to 2.3.0, the liveness probe was added (and maybe other things); this is incompatible with the 2.1.0 version.
I don't think it's necessary to use special versions for windows at this point anyway. If we do, we'll have to change the image names in the kustomize base so that we can target windows nodes anyway.
/assign @jingxu97
/assign @saikat-royc