Skip to content

Volume cloning feature #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

Volume cloning feature #854

merged 1 commit into from
Nov 24, 2021

Conversation

amacaskill
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR implements volume cloning.
Which issue(s) this PR fixes:

Fixes ##161

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enables volume cloning.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @amacaskill!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @amacaskill. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2021
@saikat-royc
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2021
@amacaskill amacaskill changed the title Volume cloning feature [WIP] Volume cloning feature Oct 21, 2021
@amacaskill
Copy link
Member Author

/assign @msau42

@amacaskill amacaskill changed the title Volume cloning feature [WIP]Volume cloning feature Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2021
mattcary
mattcary reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@mattcary mattcary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you get it working you should squash your commits.

@amacaskill amacaskill force-pushed the volume-cloning-feature branch from 1b8745e to 005e63d Compare November 9, 2021 00:26
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2021
@amacaskill amacaskill force-pushed the volume-cloning-feature branch from 005e63d to 1b8745e Compare November 10, 2021 22:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 10, 2021
@amacaskill amacaskill force-pushed the volume-cloning-feature branch from 1b8745e to a4b2fc8 Compare November 11, 2021 23:59
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 15, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@amacaskill amacaskill force-pushed the volume-cloning-feature branch from 90aab8e to 8bac170 Compare November 15, 2021 20:06
@amacaskill amacaskill changed the title [WIP]Volume cloning feature Volume cloning feature Nov 15, 2021
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 15, 2021
@amacaskill amacaskill force-pushed the volume-cloning-feature branch from ca156be to e971f8f Compare November 15, 2021 22:04
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@amacaskill amacaskill force-pushed the volume-cloning-feature branch from e971f8f to df60f26 Compare November 15, 2021 22:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@amacaskill amacaskill force-pushed the volume-cloning-feature branch 5 times, most recently from 6f2afce to 266bd71 Compare November 24, 2021 17:24
@amacaskill
parent 41bba8a
f0d15be 
author Alexis MacAskill <[email protected]> 1634669949 +0000
committer Alexis MacAskill <[email protected]> 1637713390 +0000

added volume cloning
@amacaskill amacaskill force-pushed the volume-cloning-feature branch from 71412e0 to f0d15be Compare November 24, 2021 19:07
@mattcary
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
msau42
msau42 reviewed Nov 24, 2021
View reviewed changes
test/k8s-integration/main.go
@@ -543,6 +543,9 @@ func generateGCETestSkip(testParams *testParameters) string {
if testParams.platform == "windows" {
skipString = skipString + "|\\[LinuxOnly\\]"
}
// Volume cloning has timeouts due to GCE disk cloning rate limits, and operation serialization
// race conditions where the cloning begins while the source disk is still being created.
skipString = skipString + "|provisioning\\sshould\\sprovision\\sstorage\\swith\\spvc\\sdata\\ssource[^|]*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a problem with the OSS test that can be fixed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we don't have an e2e test exercising this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a race condition in the kubernetes e2e test that is causing timeouts. This PR fixes the problem making the tests pass: kubernetes/kubernetes#106322, but it has not been merged yet. So we are skipping those tests until that PR gets merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to have to write a guitar test to cover the gap. We're talking with Jan on fixing upstream test coverage but I don't want to block on it.

@amacaskill
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit eeead67 into kubernetes-sigs:master Nov 24, 2021
@amacaskill amacaskill mentioned this pull request Jan 24, 2022
Closed
7 tasks
@amacaskill amacaskill mentioned this pull request Feb 3, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@mattcary mattcary mattcary left review comments

@leiyiz leiyiz leiyiz left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@msau42 msau42

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amacaskill @k8s-ci-robot @saikat-royc @mattcary @msau42 @leiyiz