Skip to content

Cherrypick #850 - Update go builder to 1.17 #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented Oct 19, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
It was not a clean cherrypick. I copied the changes to the files Dockerfile, added 1.17 to go.mod and ran the go mod tidy and go mod vendor. Please take a look.
Tested manually by deploying the driver and provisioning a PD volume, with a locally built image with the changes.

Does this PR introduce a user-facing change?:

Cherrypick #850 - Update go builder to 1.17

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from saad-ali October 19, 2021 18:50
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

@saikat-royc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 17fa993 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saikat-royc
Copy link
Member Author

the integration test fails the test tries to install the stable overlay driver on k8s master. Because the csidriver object in release-1.2 stable overlay uses v1beta1 api, deploy driver step fails and the overall test fails.

From the test logs:

W1019 19:13:18.664] F1019 19:13:18.655848   85586 helpers.go:115] error: unable to recognize "/tmp/gcp-compute-persistent-disk-csi-driver-specs-generated.yaml": no matches for kind "CSIDriver" in version "storage.k8s.io/v1beta1"

@msau42 I think we may need to force merge the PR. Once merged, we can test the new image by modifying the master branch prow staging rc overlay to pick the 1.2.x-rc.y image.

@saikat-royc
Copy link
Member Author

/assign @msau42

@msau42
Copy link
Contributor

msau42 commented Oct 26, 2021

lgtm for now. Maybe long term we need a way to override which k8s version the test uses.

@msau42
Copy link
Contributor

msau42 commented Oct 26, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
@saikat-royc
Copy link
Member Author

lgtm for now. Maybe long term we need a way to override which k8s version the test uses.

For release-1.3 and above branches this wont be a problem, since we have a per k8s minor overlay, and we can fix the stable-master for example (as needed) in that given branch

@saikat-royc saikat-royc merged commit 802fc41 into kubernetes-sigs:release-1.2 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants