-
Notifications
You must be signed in to change notification settings - Fork 159
Cherrypick #850 - Update go builder to 1.17 #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick #850 - Update go builder to 1.17 #852
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@saikat-royc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
the integration test fails the test tries to install the stable overlay driver on k8s master. Because the csidriver object in release-1.2 stable overlay uses v1beta1 api, deploy driver step fails and the overall test fails. From the test logs:
@msau42 I think we may need to force merge the PR. Once merged, we can test the new image by modifying the master branch prow staging rc overlay to pick the 1.2.x-rc.y image. |
/assign @msau42 |
lgtm for now. Maybe long term we need a way to override which k8s version the test uses. |
/lgtm |
For release-1.3 and above branches this wont be a problem, since we have a per k8s minor overlay, and we can fix the stable-master for example (as needed) in that given branch |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
It was not a clean cherrypick. I copied the changes to the files Dockerfile, added 1.17 to go.mod and ran the go mod tidy and go mod vendor. Please take a look.
Tested manually by deploying the driver and provisioning a PD volume, with a locally built image with the changes.
Does this PR introduce a user-facing change?: