Enable kubelet-registration-probe mode in node-driver-registrar in Windows & Linux

[mauriciopoppe]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind feature

What this PR does / why we need it:
Adds support for kubernetes-csi/node-driver-registrar#152 on Windows & Linux nodes, I tried patching previous releases to remove the probe configuration because it was introduced in node-driver-registrar v2.3.0

The output for kustomize build deploy/kubernetes/overlays/stable-1-19 is ok (liveness probe should be removed because the version is less than v2.3.0):

apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: csi-gce-pd-node-win
  namespace: gce-pd-csi-driver
spec:
  selector:
    matchLabels:
      app: gcp-compute-persistent-disk-csi-driver
  template:
    metadata:
      labels:
        app: gcp-compute-persistent-disk-csi-driver
    spec:
      containers:
      - args:
        - --v=5
        - --csi-address=unix://C:\\csi\\csi.sock
        - --kubelet-registration-path=C:\\var\\lib\\kubelet\\plugins\\pd.csi.storage.gke.io\\csi.sock
        env:
        - name: KUBE_NODE_NAME
          valueFrom:
            fieldRef:
              fieldPath: spec.nodeName
        image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.1.0
        name: csi-driver-registrar
        volumeMounts:
        - mountPath: /csi
          name: plugin-dir
        - mountPath: /registration
          name: registration-dir

Also the output for kustomize build deploy/kubernetes/overlays/stable is ok:

apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: csi-gce-pd-node-win
  namespace: gce-pd-csi-driver
spec:
  selector:
    matchLabels:
      app: gcp-compute-persistent-disk-csi-driver
  template:
    metadata:
      labels:
        app: gcp-compute-persistent-disk-csi-driver
    spec:
      containers:
      - args:
        - --v=5
        - --csi-address=unix://C:\\csi\\csi.sock
        - --kubelet-registration-path=C:\\var\\lib\\kubelet\\plugins\\pd.csi.storage.gke.io\\csi.sock
        env:
        - name: KUBE_NODE_NAME
          valueFrom:
            fieldRef:
              fieldPath: spec.nodeName
        image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.3.0
        livenessProbe:
          exec:
            command:
            - /csi-node-driver-registrar.exe
            - --kubelet-registration-path=C:\\var\\lib\\kubelet\\plugins\\pd.csi.storage.gke.io\\csi.sock
            - --mode=kubelet-registration-probe
          initialDelaySeconds: 3
        name: csi-driver-registrar
        volumeMounts:
        - mountPath: /csi
          name: plugin-dir
        - mountPath: /registration
          name: registration-dir

Does this PR introduce a user-facing change?:

NONE

/cc @jingxu97 @msau42

[mauriciopoppe]

/retest
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

[mauriciopoppe]

@jingxu97 after a discussion with the managed PD CSI team this PR is updating files that are obsolete (stable overlay), for the other overlays I think that the output is ok as shown in the description

/cc @saikat-royc

[jingxu97]

update the title and commit message?

/lgtm

[jingxu97]

/approve

[mauriciopoppe]

update the title and commit message?

done, thanks :)

[saikat-royc]

stable folder is deprecated, instead stable-{minor version}, stable-master should be updated.

[mauriciopoppe]

stable-master is already using v2.3.0 added in #828, @saikat-royc I can remove the change in stable/ if needed

[mauriciopoppe]

/retest

[saikat-royc]

/hold

We should added the changes to prow overlays first and ensure the prow runs suceeded. And when the tests are green, we also need to add to stable-master and other stable-* overlays.

Update: I see this PR is removing the probe from stable overlays, so all good. Can you add to stable-master overlay also? @mauriciopoppe

[mauriciopoppe]

@saikat-royc I've added no-node-driver-registrar-probe.yaml to stable-master too, please take a look

[saikat-royc]

we should add the no-node-driver-registrar-probe.yaml for prow rc overlays which dont have 2.3.0 registrar

[mauriciopoppe]

in its definition I saw that the prow-gke-release overlays are pulling resources from stable so changes might not be needed, I've verified that running:

kustomize build deploy/kubernetes/overlays/prow-gke-release-staging-rc-1-18
kustomize build deploy/kubernetes/overlays/prow-gke-release-staging-rc-1-19

Result in a manifest without the livenessProbe part

[saikat-royc]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, mauriciopoppe, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jingxu97,saikat-royc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[saikat-royc]

/hold cancel