Update CSI sanity to v4.2.0 #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
The fake GCE DeleteDisk() method is updated to return nil when a disk is not found to align its behavior with that of the real implementation. Some tests were skipped for now because the potential fixes are nontrivial and require more investigation. Please see issue kubernetes-sigs#818 for more details.
chrishenzie
force-pushed
the
csi-sanity-v4.2.0
branch
from
9440b5c to
d1a968c
Compare
chrishenzie
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chrishenzie
commented
Aug 12, 2021
Comment on lines
-296
to
-298
| if _, ok := cloud.disks[volKey.Name]; !ok { | ||
| return notFoundError() | ||
| } |
There was a problem hiding this comment.
For context, this was removed to align behavior with the real implementation.
|
This is in a reviewable state now, PTAL when you have a moment |
mattcary
reviewed
Aug 12, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates the CSI sanity library to the most recent release, v4.2.0.
This is important for asserting correct driver behavior and is a prerequisite for additional tests we will want to run against this driver, namely for the new NodePublishVolume behavior tied to the new access modes.
Special notes for your reviewer:
Please see #818 for more details on the skipped tests and possible solutions.
Does this PR introduce a user-facing change?:
/assign @msau42
/assign @mattcary