Refactored remote test framework for easy usage. Added teardown methods #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
msau42
reviewed
Aug 1, 2018
test/remote/setup-teardown.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| archiveName = "e2e_gce_pd_test.tar.gz" |
There was a problem hiding this comment.
can this name be more generic?
test/remote/instance.go
Outdated
| glog.V(4).Infof("Deleting instance %q", i.name) | ||
| _, err := i.computeService.Instances.Delete(i.project, i.zone, i.name).Do() | ||
| if err != nil { | ||
| if isGCEError(err, "notFound") { | ||
| return | ||
| return nil | ||
| } | ||
| glog.Errorf("Error deleting instance %q: %v", i.name, err) |
There was a problem hiding this comment.
log can be removed if you're returning the error
davidz627
force-pushed
the
feature/e2eInterface
branch
from
eff7ebe to
e6dc8b0
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @msau42