Update deployment scripts and README's #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
davidz627
force-pushed
the
fix/READMEImprove
branch
from
dd8a88b to
1456cd6
Compare
|
/assign @msau42 |
msau42
reviewed
Jun 18, 2018
| @@ -25,18 +25,16 @@ gce-pd-driver: | |||
| go build -o bin/gce-pd-csi-driver-test ./test/e2e/ | |||
|
|
|||
| build-container: gce-pd-driver | |||
| cp bin/gce-pd-csi-driver deploy/docker | |||
| docker build -t $(STAGINGIMAGE):$(STAGINGVERSION) deploy/docker | |||
| docker build -t $(STAGINGIMAGE):$(STAGINGVERSION) . | |||
There was a problem hiding this comment.
do you also want to remove references to your dev project and make that an env variable?
README.md
Outdated
| To modify dependencies or versions change `./Gopkg.toml` | ||
|
|
||
| [deployREADME]: github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/deploy/kubernetes/README.md |
There was a problem hiding this comment.
You can do relative references here
development project
davidz627
force-pushed
the
fix/READMEImprove
branch
from
1456cd6 to
41060b3
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Fixed #4 |
This was referenced Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved deployment script to build in container and reduce image size from 216MB to 6.9MB. Updated READMEs