Skip to content

use v1 CSIDriver object for 1.18+ clusters; clean up pre-1.17 versions #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,14 @@ This plugin is compatible with CSI versions [v1.2.0](https://github.com/containe
The following table captures the compatibility matrix of the core persistent disk driver binary
`gke.gcr.io/gcp-compute-persistent-disk-csi-driver`

| GCE PD CSI Driver\Kubernetes Version | 1.15 | 1.16 | 1.17+ |
|--------------------------------------|------|-------|-------|
| v0.2.x (alpha) | no | no | no |
| v0.3.x (beta) | yes | yes | yes |
| v0.4.x (beta) | yes | yes | yes |
| v0.5.x (beta) | yes | yes | yes |
| v0.6.x (beta) | yes | yes | yes |
| v0.7.x (beta) | yes | yes | yes |
| v1.0.x (ga) | yes | yes | yes |
| dev | yes | yes | yes |
| GCE PD CSI Driver\Kubernetes Version | 1.17+ |
|--------------------------------------|-------|
| v0.7.x (beta) | yes |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we want to remove the older version information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's just noise I think, especially since I also removed the older overlays as well.

| v1.0.x (ga) | yes |
| dev | yes |

The manifest bundle which captures all the driver components (driver pod which includes the containers csi-provisioner, csi-resizer, csi-snapshotter, gce-pd-driver, csi-driver-registrar;
csi driver object, rbacs, pod security policies etc) can be picked up from the master branch [overlays](deploy/kubernetes/overlays) directory. We structure the overlays directory, per minor version of kubernetes because not all driver components can be used with all kubernetes versions. For example volume snapshots are supported 1.17+ kubernetes versions thus [stable-1-16](deploy/kubernetes/overlays/stable-1-16) driver manifests does not contain the snapshotter sidecar.
csi driver object, rbacs, pod security policies etc) can be picked up from the master branch [overlays](deploy/kubernetes/overlays) directory. We structure the overlays directory, per minor version of kubernetes because not all driver components can be used with all kubernetes versions. For example, v1 CSIDriver resources are supported in 1.18+ only, so [stable-1-17](deploy/kubernetes/overlays/stable-1-17) driver manifests use the v1beta1 version.

Example:

Expand Down Expand Up @@ -84,10 +79,8 @@ GCE PD driver starts to support CSI Windows with [CSI Proxy] (https://github.com

| Feature | Stage | Min Kubernetes Master Version | Min Kubernetes Nodes Version | Min Driver Version | Deployment Overlay |
|-----------------|-------|-------------------------------|------------------------------|--------------------|--------------------|
| Snapshots | Alpha | 1.13 | Any | v0.3.0 | Alpha |
| Snapshots | Beta | 1.17 | Any | v1.0.0 | stable-1-17, stable-1-18, stable-1-19, stable-master |
| Resize (Expand) | Alpha | 1.14 | 1.14 | v0.6.0 | Alpha |
| Resize (Expand) | Beta | 1.16 | 1.16 | v0.7.0 | stable-1-16, stable-1-17, stable-1-18, stable-1-19, stable-master |
| Resize (Expand) | Beta | 1.16 | 1.16 | v0.7.0 | stable-1-17, stable-1-18, stable-1-19, stable-master |
| Windows* | Beta | 1.18 | 1.18 | v1.1.0 | stable-1-18, stable-1-19, stable-master |

\* For Windows, it is recommended to use this driver with CSI proxy v0.2.2+. The master version of driver requires disk v1beta2 group, which is only available in CSI proxy v0.2.2+
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/base/controller/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ namespace:
resources:
- cluster_setup.yaml
- controller.yaml
- csidriver_info.yaml
- psp.yaml
- v1_csidriver.yaml
7 changes: 7 additions & 0 deletions deploy/kubernetes/base/controller/v1_csidriver.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: storage.k8s.io/v1
kind: CSIDriver
metadata:
name: pd.csi.storage.gke.io
spec:
attachRequired: true
podInfoOnMount: false

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../stable-1-17
- v1beta1_csidriver.yaml
patchesStrategicMerge:
- no_v1_csidriver.yaml
transformers:
- ../../images/prow-gke-release-staging-rc-1-17
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
$patch: delete
apiVersion: storage.k8s.io/v1
kind: CSIDriver
metadata:
name: pd.csi.storage.gke.io
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#### TODO: This need to be updated to v1 once we official support 1.18+
apiVersion: storage.k8s.io/v1beta1
kind: CSIDriver
metadata:
Expand Down
20 changes: 0 additions & 20 deletions deploy/kubernetes/overlays/stable-1-15/kustomization.yaml

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

17 changes: 0 additions & 17 deletions deploy/kubernetes/overlays/stable-1-15/no_win_roles.yaml

This file was deleted.

20 changes: 0 additions & 20 deletions deploy/kubernetes/overlays/stable-1-16/kustomization.yaml

This file was deleted.

This file was deleted.

13 changes: 0 additions & 13 deletions deploy/kubernetes/overlays/stable-1-16/no_snapshotter_roles.yaml

This file was deleted.

10 changes: 0 additions & 10 deletions deploy/kubernetes/overlays/stable-1-16/no_snapshotter_sidecar.yaml

This file was deleted.

17 changes: 0 additions & 17 deletions deploy/kubernetes/overlays/stable-1-16/no_win_roles.yaml

This file was deleted.

2 changes: 2 additions & 0 deletions deploy/kubernetes/overlays/stable-1-17/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ namespace:
resources:
- ../../base/controller
- ../../base/node_linux
- v1beta1_csidriver.yaml
patchesStrategicMerge:
- no_win_roles.yaml
- no_v1_csidriver.yaml
transformers:
- ../../images/stable-1-17
5 changes: 5 additions & 0 deletions deploy/kubernetes/overlays/stable-1-17/no_v1_csidriver.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
$patch: delete
apiVersion: storage.k8s.io/v1
kind: CSIDriver
metadata:
name: pd.csi.storage.gke.io
7 changes: 7 additions & 0 deletions deploy/kubernetes/overlays/stable-1-17/v1beta1_csidriver.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: storage.k8s.io/v1beta1
kind: CSIDriver
metadata:
name: pd.csi.storage.gke.io
spec:
attachRequired: true
podInfoOnMount: false