use v1 CSIDriver object for 1.18+ clusters; clean up pre-1.17 versions #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @msau42 |
jingxu97
reviewed
May 24, 2021
| | dev | yes | yes | yes | | ||
| | GCE PD CSI Driver\Kubernetes Version | 1.17+ | | ||
| |--------------------------------------|-------| | ||
| | v0.7.x (beta) | yes | |
There was a problem hiding this comment.
so we want to remove the older version information?
There was a problem hiding this comment.
yes, it's just noise I think, especially since I also removed the older overlays as well.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mattcary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind failing-test
What this PR does / why we need it:
CI tests are failing due to trying to install v1beta1 versions of CSIDriver objects on 1.22 clusters. This PR changes deployments to use the v1 CSIDriver object on all 1.18+ clusters.