-
Notifications
You must be signed in to change notification settings - Fork 159
fix missing variable when building the image on cloudbuild #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should update this to buster 1.6.0 too. |
@mattcary done. ptal I also build the image on my cloudbuild and works fine |
/lgtm The presubmit is still not very healthy, we're working on it :-/ |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When we built the image
k8s.gcr.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:v1.2.1
we missed one parameter that needs to be set during the compilation processThis PR fix that, making it similar in how we build the image for windows.
built on my GCP account and now we can run the image without the error we saw before
We will need to release a version
v1.2.2
to fix the image issuethis PR is needed to unblock kubernetes/kubernetes#100747
/assign @msau42 @mattcary @saikat-royc
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: