Cherry-pick #757 to release-1.2 #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @mattcary |
saikat-royc
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
1 similar comment
|
/retest |
|
Oh, this isn't going to pass until my change with the kustomize fix is
cherry-picked. Let me check on it...
…On Tue, Apr 20, 2021 at 4:24 PM Kubernetes Prow Robot < ***@***.***> wrote:
@saikat-royc <https://github.com/saikat-royc>: The following test *failed*,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration a2541da
<a2541da>
link
<https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_gcp-compute-persistent-disk-csi-driver/758/pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration/1384640481610174464/> /test
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes-sigs&repo=gcp-compute-persistent-disk-csi-driver&pr=758>.
Your PR dashboard
<https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Asaikat-royc>.
Please help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/issues?q=is:issue+is:open>
when you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#758 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJCBAF6DOBKG7LACKWZYPTTJYEKLANCNFSM43I63FSA>
.
|
saikat-royc
force-pushed
the
release-1.2
branch
from
a2541da to
1521b1b
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold Actually, can you update the release note to say that you're logging the component version? I think that will look better in the changelog. |
k8s-ci-robot
added
the
do-not-merge/hold
saikat-royc
force-pushed
the
release-1.2
branch
from
1521b1b to
7ddd620
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Cherrypick #757 to release-1.2
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: