-
Notifications
You must be signed in to change notification settings - Fork 159
Build multi-arch images for ARM64 and AMD64 at the same time #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We can use buildx, which is already set up in the Makefile, to simultaneously build a multi-arch Docker image for this component for ARM64 and AMD64, such that the image will work for both architectures.
Welcome @sarandia! |
Hi @sarandia. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/ok-to-test |
/lgtm |
/retest |
1 similar comment
/retest |
I think you're running into #743. I'll have a fix out for that today. |
#743 just fixed. /retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali, sarandia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR breaks the multi-arch build. Linux build with current Dockerfile does not work for amd 64, I think. Need to consider revert this PR until the issue is fixed. See errors
|
We can use buildx, which is already set up in the Makefile, to
simultaneously build a multi-arch Docker image for this component for
ARM64 and AMD64, such that the image will work for both architectures.
What type of PR is this?
What this PR does / why we need it:
We can publish an image that is multi-arch across X86 and ARM64.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: