Skip to content

Update Stable overlay and Changelogs for 1.2.1 driver image #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented Mar 29, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
The internal prow tests for prow-staging-rc-{k8minor} with image v1.2.1-rc1 looks good. Hence submitting this PR to create a new release v1.2.1 for the driver image binary
.This PR updates the stable overlays driver manifest to use the yet to be release v1.2.1-gke.0 image, and the necessary changelogs/readme updates.

Link to the test grid: https://testgrid.corp.google.com/gcp-compute-persistent-disk-csi-driver
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

FYI once this PR is merged the cherry-pick will not be a clean one, since the release-1.2 does not have the per minor version overlays. In that cherry-pick I will manually update the stable/image.yaml file. In future release branches (say release-1.3), the overlays per k8s minor version will be picked up.

Next steps: when this PR is merged, cherry pick to release-1.2 branch and create v1.2.1 tag. Promote the image manually to gcr.io/gke-release

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2021
@saikat-royc
Copy link
Member Author

/assign @saad-ali @mattcary

@saikat-royc
Copy link
Member Author

/retest

@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit dbe766c into kubernetes-sigs:master Mar 29, 2021
k8s-ci-robot added a commit that referenced this pull request Mar 30, 2021
Update Stable images and readme (Cherrypick of #735 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants