-
Notifications
You must be signed in to change notification settings - Fork 160
Emit GKE PDCSI component version metric #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:master
from
saikat-royc:component_version_metric
Mar 1, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,124 @@ | ||
/* | ||
Copyright 2020 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package metrics | ||
|
||
import ( | ||
"fmt" | ||
"net/http" | ||
"os" | ||
|
||
"k8s.io/component-base/metrics" | ||
"k8s.io/klog" | ||
) | ||
|
||
const ( | ||
// envGKEPDCSIVersion is an environment variable set in the PDCSI controller manifest | ||
// with the current version of the GKE component. | ||
envGKEPDCSIVersion = "GKE_PDCSI_VERSION" | ||
) | ||
|
||
var ( | ||
// This metric is exposed only from the controller driver component when GKE_PDCSI_VERSION env variable is set. | ||
gkeComponentVersion = metrics.NewGaugeVec(&metrics.GaugeOpts{ | ||
Name: "component_version", | ||
Help: "Metric to expose the version of the PDCSI GKE component.", | ||
}, []string{"component_version"}) | ||
) | ||
|
||
type metricsManager struct { | ||
registry metrics.KubeRegistry | ||
} | ||
|
||
func NewMetricsManager() metricsManager { | ||
mm := metricsManager{ | ||
registry: metrics.NewKubeRegistry(), | ||
} | ||
return mm | ||
} | ||
|
||
func (mm *metricsManager) GetRegistry() metrics.KubeRegistry { | ||
return mm.registry | ||
} | ||
|
||
func (mm *metricsManager) registerComponentVersionMetric() { | ||
mm.registry.MustRegister(gkeComponentVersion) | ||
} | ||
|
||
func (mm *metricsManager) recordComponentVersionMetric() error { | ||
v := getEnvVar(envGKEPDCSIVersion) | ||
if v == "" { | ||
klog.V(2).Info("Skip emitting component version metric") | ||
return fmt.Errorf("Failed to register GKE component version metric, env variable %v not defined", envGKEPDCSIVersion) | ||
} | ||
|
||
gkeComponentVersion.WithLabelValues(v).Set(1.0) | ||
return nil | ||
} | ||
|
||
func (mm *metricsManager) EmitGKEComponentVersion() error { | ||
mm.registerComponentVersionMetric() | ||
if err := mm.recordComponentVersionMetric(); err != nil { | ||
return err | ||
} | ||
|
||
return nil | ||
} | ||
|
||
// Server represents any type that could serve HTTP requests for the metrics | ||
// endpoint. | ||
type Server interface { | ||
Handle(pattern string, handler http.Handler) | ||
} | ||
|
||
// RegisterToServer registers an HTTP handler for this metrics manager to the | ||
// given server at the specified address/path. | ||
func (mm *metricsManager) registerToServer(s Server, metricsPath string) { | ||
s.Handle(metricsPath, metrics.HandlerFor( | ||
mm.GetRegistry(), | ||
metrics.HandlerOpts{ | ||
ErrorHandling: metrics.ContinueOnError})) | ||
} | ||
|
||
// InitializeHttpHandler sets up a server and creates a handler for metrics. | ||
func (mm *metricsManager) InitializeHttpHandler(address, path string) { | ||
mux := http.NewServeMux() | ||
mm.registerToServer(mux, path) | ||
go func() { | ||
klog.Infof("Metric server listening at %q", address) | ||
if err := http.ListenAndServe(address, mux); err != nil { | ||
klog.Fatalf("Failed to start metric server at specified address (%q) and path (%q): %s", address, path, err) | ||
} | ||
}() | ||
} | ||
|
||
func getEnvVar(envVarName string) string { | ||
v, ok := os.LookupEnv(envVarName) | ||
if !ok { | ||
klog.Warningf("%q env not set", envVarName) | ||
return "" | ||
} | ||
|
||
return v | ||
} | ||
|
||
func IsGKEComponentVersionAvailable() bool { | ||
if getEnvVar(envGKEPDCSIVersion) == "" { | ||
return false | ||
} | ||
|
||
return true | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that a mux is only necessary if there are multiple handlers, so here either this or the previous version of this code would work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping mux for future proofing?