-
Notifications
You must be signed in to change notification settings - Fork 159
Switch the integration scripts and deploy driver scripts default overlays #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lay to stable-master
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/hold |
/hold cancel |
The presubmit k8s integration test with stable-master has succeeded |
/lgtm |
* Linux: Includes node yaml file and related setting that is only applicable for Linux. | ||
* Windows: Includes node yaml file and related setting that is only applicable for Windows. | ||
* `images`: It has a list of images for different versions. | ||
* `stable-master`: Image list of a stable driver for latest k8s master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about stable-{ver}
@@ -4,18 +4,21 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we combine this with the other overlay README you were writing?
What type of PR is this?
What this PR does / why we need it:
This patch will switch the existing presubmit and CI jobs to use stable-master instead of stable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Please let me know if I missed out on any prow job configs.
So far I checked
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
against this pull request should use the stable-master.Does this PR introduce a user-facing change?: