Skip to content

Switch the integration scripts and deploy driver scripts default overlays #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented Feb 19, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This patch will switch the existing presubmit and CI jobs to use stable-master instead of stable.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Please let me know if I missed out on any prow job configs.
So far I checked

  1. internal GKE test grids
  2. https://k8s-testgrid.appspot.com/provider-gcp-compute-persistent-disk-csi-driver
  3. Configs for presubmits defined here. The presubmit pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration against this pull request should use the stable-master.
  4. windows jobs are already using stable-master

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@saikat-royc
Copy link
Member Author

/assign @verult @mattcary

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 19, 2021
@saikat-royc
Copy link
Member Author

/retest

@saikat-royc
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2021
@saikat-royc
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2021
@saikat-royc
Copy link
Member Author

The presubmit k8s integration test with stable-master has succeeded

@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit c8aa168 into kubernetes-sigs:master Feb 19, 2021
* Linux: Includes node yaml file and related setting that is only applicable for Linux.
* Windows: Includes node yaml file and related setting that is only applicable for Windows.
* `images`: It has a list of images for different versions.
* `stable-master`: Image list of a stable driver for latest k8s master.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about stable-{ver}

@@ -4,18 +4,21 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we combine this with the other overlay README you were writing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants