Skip to content

Move Windows deployment to stable overlay #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

Move Windows deployment to stable overlay #701

merged 1 commit into from
Feb 10, 2021

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Feb 4, 2021 •
edited
Loading

move Windows pd csi deployent to stable overlay

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2021
@jingxu97
Copy link
Contributor Author

jingxu97 commented Feb 4, 2021

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2021
@jingxu97
Copy link
Contributor Author

jingxu97 commented Feb 4, 2021

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

1 similar comment
@jingxu97
Copy link
Contributor Author

jingxu97 commented Feb 4, 2021

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

@jingxu97
Move Windows deployment to stable overlay
dc420d6 
move Windows pd csi deployent to stable overlay
@jingxu97
Copy link
Contributor Author

jingxu97 commented Feb 5, 2021

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2021
mattcary
mattcary reviewed Feb 5, 2021
View reviewed changes
deploy/kubernetes/base/node_windows/node.yaml
@@ -24,7 +24,7 @@ spec:
kubernetes.io/os: windows
containers:
- name: csi-driver-registrar
image: gke.gcr.io/k8s-staging-csi/csi-node-driver-registrar-win
image: k8s.gcr.io/sig-storage/csi-node-driver-registrar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why we don't have to use a windows image for the registrar? Do we have a multi-arch build or something like that?

(and ditto for the driver image)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, both container images support multi-arch build now.

@jingxu97
Copy link
Contributor Author

jingxu97 commented Feb 5, 2021

/retest

1 similar comment
@jingxu97
Copy link
Contributor Author

jingxu97 commented Feb 5, 2021

/retest

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 5, 2021
@jingxu97
Copy link
Contributor Author

jingxu97 commented Feb 9, 2021

/assign @mattcary Is this PR ready to merge? Thanks!

@mattcary
Copy link
Contributor

mattcary commented Feb 9, 2021

Sorry, this got lost in my inbox.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@mattcary mattcary mentioned this pull request Feb 9, 2021
Merged
@jingxu97
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 47d319c into kubernetes-sigs:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary mattcary left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingxu97 @k8s-ci-robot @mattcary