Skip to content

Staging RC overlay: Bump all sidecar versions to latest #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

verult
Copy link
Contributor

@verult verult commented Jan 22, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Snapshotter is updated to 3.0.3 because 4.0.0 is 1.20+

Node sidecar flag changes are ignored because:

  • Node sidecar liveness probes should be changed to exec-based so they don't consume ports on user nodes.
  • Metrics manager in livenessprobe sidecar is only measuring probe CSI calls it seems.

Does this PR introduce a user-facing change?:

NONE

/assign @saikat-royc @mattcary
/cc @msau42

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 22, 2021
@k8s-ci-robot k8s-ci-robot requested a review from msau42 January 22, 2021 00:52
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2021
@mattcary
Copy link
Contributor

We have a v3.0.3 version of the snapshotter, don't we want to update to use that?

The v4 is for 1.20 IIUC.

@verult verult force-pushed the 1-2-0-sidecars-stagingrc branch from b4cb3d4 to 23d0c83 Compare January 22, 2021 01:22
@verult
Copy link
Contributor Author

verult commented Jan 22, 2021

Ah thanks, updated

@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0747042 into kubernetes-sigs:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants