Skip to content

Automated cherry pick of #691: Add Windows 2004 and 20H2 support and ability to specify a #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2021
Merged

Automated cherry pick of #691: Add Windows 2004 and 20H2 support and ability to specify a #692

merged 1 commit into from
Jan 8, 2021

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Jan 8, 2021 •
edited
Loading

Cherry pick of #691 on release-1.2.

#691: Add Windows 2004 and 20H2 support and ability to specify a

For details on the cherry pick process, see the cherry pick requests page.

-->

The Docker build argument for Windows is changed to only use one argument BASE_IMAGE which should pass the full base image name.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2021
@jingxu97
Copy link
Contributor Author

jingxu97 commented Jan 8, 2021

/assign @msau42 @jeremyje

@jeremyje
Copy link
Contributor

jeremyje commented Jan 8, 2021

/lgtm
/approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2021
@msau42
Copy link
Contributor

msau42 commented Jan 8, 2021

Can you add a release note indicating that the Docker build args changed?

@k8s-ci-robot k8s-ci-robot merged commit 29b0a50 into kubernetes-sigs:release-1.2 Jan 8, 2021
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary Awaiting requested review from mattcary

@verult verult Awaiting requested review from verult

Assignees

@jeremyje jeremyje

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jingxu97 @k8s-ci-robot @jeremyje @msau42