Skip to content

Shorten the GKE cluster name #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented Nov 18, 2020

Some intree tests create disks with names which is a combination of
cluster name + UUID, and exceeds the 63 chars limit of disk resources

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fix in-tree tests run on GKE clusters

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
For reference of how the pd name is created: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/providers/gce/gce.go#L208
Without this fix, the disk resource name is something like this gke-gcp-pd-csi-driver-test-cluster-8ac691ac-4d1f-41ed-9d6c-e528d0101609 which results in error Invalid value for field 'resource.name': 'gke-gcp-pd-csi-driver-test-cluster-8ac691ac-4d1f-41ed-9d6c-e528d0101609'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'
Does this PR introduce a user-facing change?:

NONE

Some intree tests create disks with names which is a combination of
cluster name + UUID, and exceeds the 63 chars limit of disk resources
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@saikat-royc
Copy link
Member Author

/assign @verult

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2020
@verult
Copy link
Contributor

verult commented Nov 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 20ae0e8 into kubernetes-sigs:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants