-
Notifications
You must be signed in to change notification settings - Fork 159
Add disk online/offline into Stage/Unstage volumes #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Disk might be offline when attaching to VMs due to different reasons. Add disk online logic into NodeStageVolume to make sure disk can be accessed. Also add disk offline logic into NodeUnstageVolume to make sure disk is in a clean state when detaching from VM. Disk online/offline API is in csi proxy disk.v1beta2 api group, so updating to use this group
60cecc1
to
c988802
Compare
cc @msau42 |
@@ -9,7 +9,7 @@ require ( | |||
github.com/golang/protobuf v1.4.2 | |||
github.com/google/uuid v1.1.1 | |||
github.com/hashicorp/go-multierror v1.0.0 // indirect | |||
github.com/kubernetes-csi/csi-proxy/client v0.2.1 | |||
github.com/kubernetes-csi/csi-proxy/client v0.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the README as well to indicate we have a newer csi proxy dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I will have another PR to update it.
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019 |
/lgtm |
@jingxu97: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Disk might be offline when attaching to VMs due to different reasons.
Add disk online logic into NodeStageVolume to make sure disk can be
accessed. Also add disk offline logic into NodeUnstageVolume to make
sure disk is in a clean state when detaching from VM.
Disk online/offline API is in csi proxy disk.v1beta2 api group, so
updating to use this group
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: