Skip to content

Update dev overlay so that image overwrite can work #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

Update dev overlay so that image overwrite can work #654

merged 1 commit into from
Nov 3, 2020

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Oct 31, 2020 •
edited
Loading

After PR #610 change, in current dev overlay, kustomization will not work well with image
setting (overwriting)

Modify the structure to fix it.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #650
Fixes #649

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2020
@jingxu97
Copy link
Contributor Author

/assign @mattcary

@mattcary
Copy link
Contributor

mattcary commented Nov 2, 2020

Can you check that this still works with the noauth overlay?

Kustomize is sort of a mess to reason about, but I recall there being problems there with an image transform in the dev overlay.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2020
@jingxu97
Copy link
Contributor Author

jingxu97 commented Nov 2, 2020

Can you check that this still works with the noauth overlay?

Kustomize is sort of a mess to reason about, but I recall there being problems there with an image transform in the dev overlay.

good catch! I modified the noauth overlay too so that image setting is correct. PTAL

@jingxu97
Update dev overlay so that image overwrite can work
c257648 
In current dev overlay, kustomization will not work well with image
setting (overwriting)

Modify the structure to fix it.
@jingxu97
Copy link
Contributor Author

jingxu97 commented Nov 3, 2020

@mattcary I updated the PR, PTAL. Thanks!

@mattcary
Copy link
Contributor

mattcary commented Nov 3, 2020

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit f96028f into kubernetes-sigs:master Nov 3, 2020
@jingxu97 jingxu97 mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@jingxu97 @k8s-ci-robot @mattcary