Skip to content

Cherrypick #644, #647, #652 from master to release-1.1 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2020

Conversation

saad-ali
Copy link
Contributor

@saad-ali saad-ali commented Oct 30, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Cherrypick #647 from master to release-1.1: Update kustomizer to 3.8.6
Cherrypick #644 from master to release-1.1: Add release notes for 1.1.0 release
Cherrypick #652 from master to release-1.1: Update staging RC to use new 1.1.0 RC build

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

/assign @jingxu97
/assign @msau42

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2020
@msau42
Copy link
Contributor

msau42 commented Oct 31, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2020
@saad-ali
Copy link
Contributor Author

Test failed:

W1031 00:30:45.400] F1031 00:30:45.399921    3277 main.go:161] Failed to run integration test: failed to install CSI Driver: failed to install kustomize: installing kustomize
W1031 00:30:45.401] curl: no URL specified!
W1031 00:30:45.401] curl: try 'curl --help' or 'curl --manual' for more information
W1031 00:30:45.402] , err: exit status 123
W1031 00:30:45.416] Traceback (most recent call last):
W1031 00:30:45.417]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 50, in <module>
W1031 00:30:45.417]     main(ARGS.env, ARGS.cmd + ARGS.args)
W1031 00:30:45.418]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 41, in main
W1031 00:30:45.418]     check(*cmd)
W1031 00:30:45.418]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 30, in check
W1031 00:30:45.419]     subprocess.check_call(cmd)
W1031 00:30:45.419]   File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
W1031 00:30:45.419]     raise CalledProcessError(retcode, cmd)
W1031 00:30:45.419] subprocess.CalledProcessError: Command '('test/run-k8s-integration.sh',)' returned non-zero exit status 255
E1031 00:30:45.452] Command failed
I1031 00:30:45.453] process 630 exited with code 1 after 34.9m
E1031 00:30:45.454] FAIL: pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Per #649 the fix is in #647 -- that PR should be cherry picked to the release branch first.

jingxu97 and others added 2 commits October 30, 2020 17:39
Update kustomizer to 3.8.6 due to issue to download 3.8.0
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2020
@jingxu97
Copy link
Contributor

this is caused by kustimization release download does not include 3.8.0 which we specified in the script. I already fix it in #647

@saad-ali
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2020
@saad-ali saad-ali changed the title Cherrypick #644 from master to release-1.1: Add release notes for 1.1.0 release Cherrypick #644, #647 from master to release-1.1 Oct 31, 2020
@saad-ali
Copy link
Contributor Author

Added #647 to the cherry pick.
PTAL

@saad-ali
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2020
@saad-ali saad-ali changed the title Cherrypick #644, #647 from master to release-1.1 Cherrypick #644, #647, #652 from master to release-1.1 Oct 31, 2020
@msau42
Copy link
Contributor

msau42 commented Oct 31, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit d0d7f59 into kubernetes-sigs:release-1.1 Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants