Migrate from alpha to beta compute APIs #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XXL
|
/assign @saikat-royc |
alculquicondor
force-pushed
the
compute-beta
branch
from
cdd7f0c to
67f63c2
Compare
k8s-ci-robot
added
size/L
mattcary
reviewed
Oct 29, 2020
| var diskToCreate *CloudDisk | ||
| computeDisk := &computev1.Disk{ | ||
| Name: volKey.Name, | ||
| Zone: volKey.Zone, |
There was a problem hiding this comment.
It looks like computeDisk.Zone is set in the meta.Zonal case below, and unused in the meta.Regional case. Maybe best not to set it here?
There was a problem hiding this comment.
You are right. Removed
k8s-ci-robot
added
the
lgtm
And reduce code duplication on compute Disk wrappers
alculquicondor
force-pushed
the
compute-beta
branch
from
67f63c2 to
2c2ff1f
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @msau42 |
|
/approve oops |
k8s-ci-robot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mattcary, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The only Disk feature that required an alpha API (multiwriter) is now in beta.
We keep the infrastructure to be able to swap API versions, but it has been simplified to reduce code duplication.
Special notes for your reviewer:
Builds on top of #642
Does this PR introduce a user-facing change?: