Skip to content

Add Volume Resize support for Windows #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add Volume Resize support for Windows #637

merged 1 commit into from
Oct 27, 2020

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Oct 21, 2020 •
edited
Loading

This PR adds the volume resize support for Window

Have tested volume expansion test cases locally. Will open another PR to enable the tests.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add volume expansion support for Windows in GCE PD CSI driver

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2020
@jingxu97
Copy link
Contributor Author

/assign @msau42 @saad-ali

@jingxu97
Add Volume Resize support for Windows
96b49ad 
This PR adds the volume resize support for Window
msau42
msau42 reviewed Oct 22, 2020
View reviewed changes
pkg/resizefs/resizefs_windows.go
request := &volumeapi.ResizeVolumeRequest{
VolumeId: volumeId,
}
_, err = proxy.VolumeClient.ResizeVolume(context.Background(), request)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to check filesystem type or does this imply ntfs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It implies ntfs, no need to check fs type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there ever is a need for multiple fs support, will the csi proxy be able to automatically figure out what to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this volumeclient API, it means ntfs volume, and all functions through volume API client assumes that.
So far there is no other type to support resize. In case, for example, smb support resize, then the API will be in smb API group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking something like ext4 in the future, where it also belongs in the volume client. Anyway, I posed the question in slack. For this pr, this is fine.

@jingxu97
Copy link
Contributor Author

@msau42 could you also check this one so that when tests are triggered, resize support is available?

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 27, 2020
@msau42
Copy link
Contributor

msau42 commented Oct 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2020
@msau42
Copy link
Contributor

msau42 commented Oct 27, 2020

/hold
can you add a release note?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 27, 2020
@jingxu97
Copy link
Contributor Author

/hold
can you add a release note?

added. THanks!

@msau42
Copy link
Contributor

msau42 commented Oct 27, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 929d795 into kubernetes-sigs:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@mattcary mattcary Awaiting requested review from mattcary

@verult verult Awaiting requested review from verult

Assignees

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jingxu97 @k8s-ci-robot @msau42 @saad-ali