Build only linux container image for tests on Linux #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build multi-arch container image takes much longer time than only building linux container image. This PR changes back to only build linux container image for linux tests to avoid timeout issue
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
cc @saad-ali |
k8s-ci-robot
added
release-note-none
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
yuga711
reviewed
Oct 22, 2020
| if err != nil { | ||
| return fmt.Errorf("failed to run make command for windows: err: %v", err) | ||
| if platform == "windows" { | ||
| // build multi-arch image which can work for both Linux and Windows |
There was a problem hiding this comment.
May be worth add a comment to clarify why multi-arch is applied only for windows. Something like: "multi-arch build takes long time, apply only for non-Linux platforms"
| err = runCommand("Building and Pushing GCP Container for Windows", cmd) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to run make command for windows: err: %v", err) | ||
| if platform == "windows" { |
There was a problem hiding this comment.
nit: May be good to apply fast build for Linux and multi-arch for everything else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build multi-arch container image takes much longer time than only
building linux container image. This PR changes back to only build linux
container image for linux tests to avoid timeout issue
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: