-
Notifications
You must be signed in to change notification settings - Fork 159
Enable dump GKE node logs #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dump GKE node logs #635
Conversation
@saikat-royc: GitHub didn't allow me to request PR reviews from the following users: tosi3k. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @verult |
I'm not sure whether I'm an appropriate person for reviewing this PR given I don't own this code but OTOH I was the one that suggested that fix :D. /lgtm |
@tosi3k: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, saikat-royc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Capturing the flow here:
This patch uses kubetest --dump flag instead of directly setting up --report-dir flag. If dump flag is provided, kubetest will setup report-dir here. Also using dump flag, enables kubetest to call DumpClusterLogs for both GCE and GKE deployments. For GKE, the function will setup the enviroment variables and filters here. For GKE deployment, this enables log-dump.sh to find the node names for GKE and also gracefully skip master dump. The above dump flag works for both zonal and regional GKE clusters.
Also with this change, we do not need the change kubernetes/kubernetes#95088. I will be closing that PR once this one is reviewed.
Does this PR introduce a user-facing change?: