Skip to content

Enable dump GKE node logs #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented Oct 20, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Capturing the flow here:
This patch uses kubetest --dump flag instead of directly setting up --report-dir flag. If dump flag is provided, kubetest will setup report-dir here. Also using dump flag, enables kubetest to call DumpClusterLogs for both GCE and GKE deployments. For GKE, the function will setup the enviroment variables and filters here. For GKE deployment, this enables log-dump.sh to find the node names for GKE and also gracefully skip master dump. The above dump flag works for both zonal and regional GKE clusters.

Also with this change, we do not need the change kubernetes/kubernetes#95088. I will be closing that PR once this one is reviewed.
Does this PR introduce a user-facing change?:

Enable dump GKE node logs

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2020
@saikat-royc
Copy link
Member Author

/cc @tosi3k @msau42

@k8s-ci-robot
Copy link
Contributor

@saikat-royc: GitHub didn't allow me to request PR reviews from the following users: tosi3k.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tosi3k @msau42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saikat-royc
Copy link
Member Author

/cc @verult

@k8s-ci-robot k8s-ci-robot requested a review from verult October 20, 2020 05:34
@tosi3k
Copy link

tosi3k commented Oct 20, 2020

I'm not sure whether I'm an appropriate person for reviewing this PR given I don't own this code but OTOH I was the one that suggested that fix :D.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tosi3k: changing LGTM is restricted to collaborators

In response to this:

I'm not sure whether I'm an appropriate person for reviewing this PR given I don't own this code but OTOH I was the one that suggested that fix :D.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42
Copy link
Contributor

msau42 commented Oct 20, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d4c82a5 into kubernetes-sigs:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants