Skip to content

Enable XFS selectively for GKE clusters with proper COS support #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

Enable XFS selectively for GKE clusters with proper COS support #632

merged 1 commit into from
Nov 2, 2020

Conversation

mattcary
Copy link
Contributor

/kind bug

What this PR does / why we need it:
Since kubernetes/kubernetes#95527 enables XFS on COS in the e2e tests, the PD CSI tests need to selectively disable it when the test on GKE versions without newer COS versions.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2020
@mattcary
Copy link
Contributor Author

/assign @msau42

Note: this compiles but I haven't tested it yet, I wanted to make sure this made sense to you first

msau42
msau42 reviewed Oct 13, 2020
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2020
@mattcary
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@mattcary mattcary force-pushed the gke-xfs branch 2 times, most recently from d4356c3 to fa8f167 Compare October 16, 2020 00:49
@msau42
Copy link
Contributor

msau42 commented Oct 16, 2020

/assign @saikat-royc

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 16, 2020
@saikat-royc
Copy link
Member

saikat-royc commented Oct 22, 2020 •
edited
Loading

The change looks good to me overall with some minor comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2020
@mattcary
Copy link
Contributor Author

/retest

saikat-royc
saikat-royc reviewed Oct 26, 2020
View reviewed changes
test/k8s-integration/driver-config.go Outdated
case "gke":
fallthrough
case "gce":
caps = append(caps, "controllerExpansion", "nodeExpansion")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For "GCE", looks like controllerexpansion and node expansion are getting skipped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added above since they're used in all deployments now.

@mattcary
Copy link
Contributor Author

rate limit exceeded on the e2e test

/retest

@saikat-royc
Copy link
Member

/retest

@jingxu97
Copy link
Contributor

jingxu97 commented Nov 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit b9c4467 into kubernetes-sigs:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saikat-royc saikat-royc saikat-royc left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@jingxu97 jingxu97

@msau42 msau42

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattcary @k8s-ci-robot @msau42 @saikat-royc @jingxu97