Add VolumeStats for Windows #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/retest |
|
/retest |
mattcary
reviewed
Oct 9, 2020
pkg/mount-manager/statter_windows.go
Outdated
| zero := int64(0) | ||
| return zero, zero, zero, zero, zero, zero, fmt.Errorf("Not implemented") | ||
| //return zero, zero, zero, zero, zero, zero, fmt.Errorf("Not implemented") |
pkg/gce-pd-csi-driver/node.go
Outdated
| @@ -412,7 +412,7 @@ func (ns *GCENodeServer) NodeGetVolumeStats(ctx context.Context, req *csi.NodeGe | |||
| }, nil | |||
| } | |||
|
|
|||
| available, capacity, used, inodesFree, inodes, inodesUsed, err := ns.VolumeStatter.StatFS(req.VolumePath) | |||
| available, capacity, used, inodesFree, inodes, inodesUsed, err := getStatFS(ns.VolumeStatter, req.VolumePath) | |||
There was a problem hiding this comment.
I don't understand why have to to thunk through getStatFS and can't just use the Statter interface directly?
There was a problem hiding this comment.
you are right, directly use Statter is good. I kind of follow some other calls, which seem have to use this route.
updated the code. PTAL
add support for getting volume stats for windows
|
/assign |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for getting volume stats for windows. Tested on Windows node with following and it is working.
note: Inode is not available for windows.
invoke-webrequest http://localhost:10255/metrics -outfile metrics
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #628
Special notes for your reviewer:
Does this PR introduce a user-facing change?: