-
Notifications
You must be signed in to change notification settings - Fork 159
Update driver to use csi proxy filesystem v1beta1 #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @msau42 |
/lgtm |
Looks like the v1beta for filesystem isn't updated in vendor? |
my mistake. forgot to git add those files.. |
1 Update driver to use lastest csi proxy with filesystem v1beta1 2 Update csi-proxy vendor 3 Update psp for windows to use v1beta1 for filesystem pipe 4 update service account for windows
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-ltsc2019 /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-1909 |
@jingxu97: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019 |
cc @mattcary I added vendor file. PTAL. Thanks! |
It doesn't look like those windows e2e tests have much history? Maybe windows machines need more startup time or whatever & the timeouts are too low? |
I think that's because I recently changed the test name to have version information. The tests now are broken I need to fix some multi-arch build issue. I plan to have a separate PR to fix test issue. So could we merge this one first? |
/lgtm Sure, sgtm |
@jingxu97: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
1 Update driver to use lastest csi proxy with filesystem v1beta1
2 Update csi-proxy vendor
3 Update psp for windows to use v1beta1 for filesystem pipe
4 update service account for windows
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: