Skip to content

Update driver to use csi proxy filesystem v1beta1 #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Sep 17, 2020

1 Update driver to use lastest csi proxy with filesystem v1beta1
2 Update csi-proxy vendor
3 Update psp for windows to use v1beta1 for filesystem pipe
4 update service account for windows

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 17, 2020
@jingxu97
Copy link
Contributor Author

cc @msau42

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2020
@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2020
@mattcary
Copy link
Contributor

Looks like the v1beta for filesystem isn't updated in vendor?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 18, 2020
@jingxu97
Copy link
Contributor Author

Looks like the v1beta for filesystem isn't updated in vendor?

my mistake. forgot to git add those files..

1 Update driver to use lastest csi proxy with filesystem v1beta1
2 Update csi-proxy vendor
3 Update psp for windows to use v1beta1 for filesystem pipe
4 update service account for windows
@jingxu97
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-ltsc2019

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-1909

@k8s-ci-robot
Copy link
Contributor

@jingxu97: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-gcp-compute-persistent-disk-csi-driver-e2e
  • /test pull-gcp-compute-persistent-disk-csi-driver-sanity
  • /test pull-gcp-compute-persistent-disk-csi-driver-unit
  • /test pull-gcp-compute-persistent-disk-csi-driver-verify
  • /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration
  • /test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019
  • /test pull-gcp-compute-persistent-disk-csi-driver-e2e-win1909
  • /test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-1-19

Use /test all to run the following jobs:

  • pull-gcp-compute-persistent-disk-csi-driver-e2e
  • pull-gcp-compute-persistent-disk-csi-driver-sanity
  • pull-gcp-compute-persistent-disk-csi-driver-unit
  • pull-gcp-compute-persistent-disk-csi-driver-verify
  • pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

In response to this:

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-ltsc2019

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-1909

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jingxu97
Copy link
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019
/test pull-gcp-compute-persistent-disk-csi-driver-e2e-win1909

@jingxu97
Copy link
Contributor Author

cc @mattcary I added vendor file. PTAL. Thanks!

@mattcary
Copy link
Contributor

It doesn't look like those windows e2e tests have much history? Maybe windows machines need more startup time or whatever & the timeouts are too low?

@jingxu97
Copy link
Contributor Author

jingxu97 commented Sep 18, 2020

I think that's because I recently changed the test name to have version information. The tests now are broken I need to fix some multi-arch build issue.

I plan to have a separate PR to fix test issue. So could we merge this one first?

@jingxu97
Copy link
Contributor Author

cc @mattcary @msau42 PTAL. thanks!

@mattcary
Copy link
Contributor

/lgtm

Sure, sgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 21, 2020

@jingxu97: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019 ac253f3 link /test pull-gcp-compute-persistent-disk-csi-driver-e2e-win2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jingxu97
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2a53287 into kubernetes-sigs:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants