Skip to content

Added controller unit tests #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

Added controller unit tests #58

merged 1 commit into from
Jul 10, 2018

Conversation

davidz627
Copy link
Contributor

Fixes: #46

/assign @msau42

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2018
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali July 10, 2018 22:32
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2018
@davidz627 davidz627 force-pushed the feature/controllerTests branch from 3d53ff6 to e5bf816 Compare July 10, 2018 22:33
@davidz627 davidz627 force-pushed the feature/controllerTests branch from e5bf816 to 2ccf1ac Compare July 10, 2018 22:39
msau42
msau42 reviewed Jul 10, 2018
View reviewed changes
Copy link
Contributor

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 890790c into kubernetes-sigs:master Jul 10, 2018
@davidz627 davidz627 deleted the feature/controllerTests branch July 10, 2018 22:59
tsmetana pushed a commit to tsmetana/gcp-compute-persistent-disk-csi-driver that referenced this pull request Jan 23, 2024
@openshift-merge-bot
Merge pull request kubernetes-sigs#58 from dobsonj/OCPBUGS-27242
587ce11 
OCPBUGS-27242: fix or ignore snyk errors for ocp storage repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidz627 @k8s-ci-robot @msau42