Skip to content

Promote CSIDriver deployment to stable #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2020
Merged

Promote CSIDriver deployment to stable #575

merged 1 commit into from
Aug 8, 2020

Conversation

Jiawei0227
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Promote CSIDriver object deployment to GA

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Install CSIDriver object as part of driver deployment.

/cc @saad-ali
/cc @verult
/cc @saikat-royc

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Jiawei0227. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2020
saikat-royc
saikat-royc reviewed Aug 7, 2020
View reviewed changes
deploy/kubernetes/base/controller/cluster_setup.yaml Outdated
@@ -272,3 +272,12 @@ roleRef:
kind: Role
name: csi-gce-pd-leaderelection-role
apiGroup: rbac.authorization.k8s.io

Copy link
Member

@saikat-royc saikat-royc Aug 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this in a separate file? given that cluster setup has only rbac rules? @msau42 thoughts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@saad-ali saad-ali added this to the GA milestone Aug 7, 2020
@Jiawei0227 Jiawei0227 force-pushed the csidriver3 branch 3 times, most recently from 1c80984 to 1f0ab72 Compare August 7, 2020 21:31
saikat-royc
saikat-royc reviewed Aug 7, 2020
View reviewed changes
Copy link
Member

@saikat-royc saikat-royc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update deploy/kubernetes/base/controller/kustomization.yaml to include csidriver file.

@Jiawei0227
Copy link
Contributor Author

Oops, sorry. Done

@saikat-royc
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2020
@msau42
Copy link
Contributor

msau42 commented Aug 7, 2020

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0bb37c1 into kubernetes-sigs:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikat-royc saikat-royc saikat-royc left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@verult verult Awaiting requested review from verult

Assignees

@saikat-royc saikat-royc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
GA
Development

Successfully merging this pull request may close these issues.
5 participants
@Jiawei0227 @k8s-ci-robot @saikat-royc @msau42 @saad-ali