-
Notifications
You must be signed in to change notification settings - Fork 159
Change CSIDriver object version to v1beta1 to be compatible with k8s version #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Jiawei0227. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should we include the changes of csidriver for prow-staging-head overlay too? @msau42 |
Sure that's a good practice to follow |
deploy/kubernetes/overlays/prow-gke-release-staging-head/csi-driver.yaml
Outdated
Show resolved
Hide resolved
/lgtm |
What type of PR is this?
What this PR does / why we need it:
1.16 and 1.17 tests are failing because we are using CSIDriver version v1. It only changes to v1 on 1.18. So before that we should use v1beta1 for CSIDriver object.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @verult
/cc @msau42
/cc @saikat-royc