-
Notifications
You must be signed in to change notification settings - Fork 159
Add CSIDriver object into driver deployment script #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @Jiawei0227! |
Hi @Jiawei0227. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jiawei! Feel free to ignore nits
We don't need a release note yet since it's not a stable release
@@ -2,6 +2,7 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
kind: Kustomization | |||
resources: | |||
- ../stable | |||
- ./csi-driver.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: ./
shouldn't be necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think I will leave it here because anyways we will move this to stable so it will be deleted. :)
/lgtm Leaving a hold in case you want to fix the nit. Otherwise "/hold cancel" will do. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/hold cancel |
What type of PR is this?
What this PR does / why we need it:
This PR adds CSIDriver object into the deployment script.
Which issue(s) this PR fixes:
Fixes #564
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @saad-ali
/cc @verult