Skip to content

Adding Kustomize structure in deployment README #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

verult
Copy link
Contributor

@verult verult commented Jul 25, 2020

Based on #520 (comment)

What type of PR is this?
/kind documentation

Does this PR introduce a user-facing change?:

NONE

/assign @jingxu97 @msau42

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali July 25, 2020 00:42
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2020
@verult
Copy link
Contributor Author

verult commented Jul 25, 2020

/cc @misterikkit

@k8s-ci-robot k8s-ci-robot requested a review from misterikkit July 25, 2020 00:43
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2020
@verult verult changed the title Kustomize structure in deployment README Adding Kustomize structure in deployment README Jul 25, 2020
* Windows: includes node yaml file and related setting that is only applicable for Windows.
* `images`: it has a list of images for different versions.
* `stable`: currently only has image list for Linux stable version.
* `alpha`: besides image list in stable, it also includes Windows image updates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will become out of date once Windows is out of alpha. Should we make this more generic and say it's images used for alpha features? ditto throughout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Linux and Windows support should be mentioned for each bullet because it's part of the Kustomization complexity, but I'll update it to mention it's more generally used for features in development.

* Windows: includes node yaml file and related setting that is only applicable for Windows.
* `images`: it has a list of images for different versions.
* `stable`: image list of a stable driver release. Currently only has image list for Linux stable version.
* `alpha`: image list containing features in development, in addition to images in stable. It also includes Windows images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention the reason windows images are only included here because the support for windows is still alpha?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a line up top

@msau42
Copy link
Contributor

msau42 commented Jul 31, 2020

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2020
@verult
Copy link
Contributor Author

verult commented Aug 5, 2020

/retest

1 similar comment
@jingxu97
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6b61753 into kubernetes-sigs:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants