-
Notifications
You must be signed in to change notification settings - Fork 159
Adding Kustomize structure in deployment README #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @misterikkit |
deploy/kubernetes/README.md
Outdated
* Windows: includes node yaml file and related setting that is only applicable for Windows. | ||
* `images`: it has a list of images for different versions. | ||
* `stable`: currently only has image list for Linux stable version. | ||
* `alpha`: besides image list in stable, it also includes Windows image updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become out of date once Windows is out of alpha. Should we make this more generic and say it's images used for alpha features? ditto throughout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Linux and Windows support should be mentioned for each bullet because it's part of the Kustomization complexity, but I'll update it to mention it's more generally used for features in development.
* Windows: includes node yaml file and related setting that is only applicable for Windows. | ||
* `images`: it has a list of images for different versions. | ||
* `stable`: image list of a stable driver release. Currently only has image list for Linux stable version. | ||
* `alpha`: image list containing features in development, in addition to images in stable. It also includes Windows images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe mention the reason windows images are only included here because the support for windows is still alpha?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a line up top
/lgtm |
/retest |
1 similar comment
/retest |
Based on #520 (comment)
What type of PR is this?
/kind documentation
Does this PR introduce a user-facing change?:
/assign @jingxu97 @msau42