Skip to content

enabling leader election in stable overlay #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

verult
Copy link
Contributor

@verult verult commented Jun 5, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it: Enables leader election by default in driver deployment. Prevents controller races when multiple replicas are deployed.

Controller deployment uses a Deployment instead of a StatefulSet, since by default the single controller replica does not run in a dedicated node. See here for detailed rationale.

Which issue(s) this PR fixes:

Fixes #516

Does this PR introduce a user-facing change?:

The driver deployment now has leader election enabled, and the controller deployment uses a Deployment instead of a StatefulSet.

/assign @msau42
/cc @ffilippopoulos

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

@verult: GitHub didn't allow me to request PR reviews from the following users: ffilippopoulos.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind feature

What this PR does / why we need it: Enables leader election by default in driver deployment. Prevents controller races when multiple replicas are deployed.

Controller deployment uses a Deployment instead of a StatefulSet, since by default the single controller replica does not run in a dedicated node. See here for detailed rationale.

Which issue(s) this PR fixes:

Fixes #516

Does this PR introduce a user-facing change?:

The driver deployment now has leader election enabled, and the controller deployment uses a Deployment instead of a StatefulSet.

/assign @msau42
/cc @ffilippopoulos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2020
@msau42
Copy link
Contributor

msau42 commented Jun 5, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, verult

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 317f2a6 into kubernetes-sigs:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race when running multiple controller replicas
3 participants