Adding leader election to controllers in staging rc #518
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| # for external-provisioner | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "--enable-leader-election" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "--leader-election-type=leases" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "--leader-election-namespace=$(PDCSI_NAMESPACE)" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/0/env | ||
| value: | ||
| - name: PDCSI_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
|
|
||
|
|
||
| # # for external-attacher | ||
| - op: add | ||
| path: /spec/template/spec/containers/1/args/- | ||
| value: "--leader-election" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/1/args/- | ||
| value: "--leader-election-namespace=$(PDCSI_NAMESPACE)" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/1/env | ||
| value: | ||
| - name: PDCSI_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
|
|
||
|
|
||
| # # for external-resizer | ||
| - op: add | ||
| path: /spec/template/spec/containers/2/args/- | ||
| value: "--leader-election" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/2/args/- | ||
| value: "--leader-election-namespace=$(PDCSI_NAMESPACE)" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/2/env | ||
| value: | ||
| - name: PDCSI_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.namespace | ||
|
|
||
|
|
||
| # for external-snapshotter | ||
| - op: add | ||
| path: /spec/template/spec/containers/3/args/- | ||
| value: "--leader-election" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/3/args/- | ||
| value: "--leader-election-namespace=$(PDCSI_NAMESPACE)" | ||
|
|
||
| - op: add | ||
| path: /spec/template/spec/containers/3/env | ||
| value: | ||
| - name: PDCSI_NAMESPACE | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.namespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| kind: Role | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: csi-gce-pd-leaderelection-role | ||
| namespace: gce-pd-csi-driver | ||
| labels: | ||
| k8s-app: gcp-compute-persistent-disk-csi-driver | ||
| rules: | ||
| - apiGroups: ["coordination.k8s.io"] | ||
| resources: ["leases"] | ||
| verbs: ["get", "watch", "list", "delete", "update", "create"] | ||
| --- | ||
| kind: RoleBinding | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: csi-gce-pd-controller-leaderelection-binding | ||
| namespace: gce-pd-csi-driver | ||
| labels: | ||
| k8s-app: gcp-compute-persistent-disk-csi-driver | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: csi-gce-pd-controller-sa | ||
| roleRef: | ||
| kind: Role | ||
| name: csi-gce-pd-leaderelection-role | ||
| apiGroup: rbac.authorization.k8s.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| - op: remove | ||
| path: "/spec/serviceName" | ||
| - op: remove | ||
| path: "/spec/volumeClaimTemplates" | ||
| - op: replace | ||
| path: /kind | ||
| value: Deployment |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to switch to a Deployment as well? I think it's not easily done without modifying the base too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaning towards optimizing for the common case of 1 replica. I think this is the common case, but if we have indicators otherwise we could change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's set the pod management policy to "parallel" then? That way the statefulset won't get stuck if one of the replicas fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually looking at the design doc again, StatefulSet is good for a dedicated node, which is probably usually not the case for this deployment. I can switch it to Deployment.
At some point I managed to change the
kindwith a Kustomize JSON patch. Will see if I can still do it :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this low risk enough to just do it in the base. There's probably other spec differences between StatefulSet and Deployment too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got the patching figured out. I pushed a new version
I believe the default of maxUnavailable = 25% (rounded down, so 0) and maxSurge = 25% (rounded up, so 1) is OK - a new replica will be created first, in standby, before the old replica is deleted.