Skip to content

Add option to deploy GKE managed PD CSI driver for integration tests #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2020
Merged

Add option to deploy GKE managed PD CSI driver for integration tests #515

merged 1 commit into from
Jun 12, 2020

Conversation

saikat-royc
Copy link
Member

@saikat-royc saikat-royc commented May 27, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Add hook to deploy GKE with GCE PD CSI driver, and run kubernetes e2e tests against the managed driver.
Summary of changes:
1. Add a new hook to pass release-channel for GKE cluster deployment.
2. Add a new hook to deploy GKE managed PD CSI driver.
3. Added a version comparision util with supporting UTs.
Which issue(s) this PR fixes:

Fixes #511

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add hook to deploy GKE with GCE PD CSI driver, and run kubernetes e2e tests against the managed driver

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @saikat-royc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from davidz627 and verult May 27, 2020 20:56
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2020
@saikat-royc
Copy link
Member Author

/cc @msau42 @verult

@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 27, 2020 20:56
@msau42
Copy link
Contributor

msau42 commented May 27, 2020

/assign @verult
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
mattcary
mattcary reviewed May 28, 2020
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2020
verult
verult reviewed Jun 1, 2020
View reviewed changes
Copy link
Contributor

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2020
@saikat-royc
Copy link
Member Author

/retest

1 similar comment
@saikat-royc
Copy link
Member Author

/retest

@saikat-royc
Copy link
Member Author

/retest

@saikat-royc saikat-royc force-pushed the issue-511 branch 3 times, most recently from b15c57a to 7a3ea7b Compare June 4, 2020 23:08
verult
verult reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@verult verult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end!

mattcary
mattcary approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@mattcary mattcary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well, thanks!

msau42
msau42 reviewed Jun 10, 2020
View reviewed changes
Copy link
Contributor

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2020
@saikat-royc
Copy link
Member Author

/retest

1 similar comment
@saikat-royc
Copy link
Member Author

/retest

@saikat-royc
Add option to deploy GKE managed PD CSI driver for integration tests
77f4be8 
Summary of changes:
1. Add a new hook to pass release-channel for GKE cluster deployment.
2. Add a new hook to deploy GKE managed PD CSI driver.
3. Added a GKE version comparision util with supporting UTs.
@msau42
Copy link
Contributor

msau42 commented Jun 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7e03d6d into kubernetes-sigs:master Jun 12, 2020
@saikat-royc saikat-royc mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verult verult verult left review comments

@msau42 msau42 msau42 left review comments

@mattcary mattcary mattcary approved these changes

@davidz627 davidz627 Awaiting requested review from davidz627

Assignees

@verult verult

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Driver integration test should support option to deploy GKE managed PD CSI driver
5 participants
@saikat-royc @k8s-ci-robot @msau42 @verult @mattcary