Add unit test runner script. Fixed some errors caught by unit tests #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
msau42
reviewed
Jul 3, 2018
| @@ -52,23 +52,38 @@ const ( | |||
| attachableDiskTypePersistent = "PERSISTENT" | |||
| ) | |||
|
|
|||
| func getRequestCapacity(capRange *csi.CapacityRange) (capBytes int64) { | |||
| func getRequestCapacity(capRange *csi.CapacityRange) (int64, error) { | |||
There was a problem hiding this comment.
You may want to check out what I did for this (in fact, it should probably be a utility function that can be shared by multiple drivers), and my test cases.
There was a problem hiding this comment.
I wrote some tests for this function in a followup PR. Lets work on a canonical getRequestCapacity.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest wow this test is flaky |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of: #49
Part 2 will be adding run-unit.sh to the test-infra config
/assign @msau42