Skip to content

Enable csi snapshotter in stable overlay #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2020
Merged

Enable csi snapshotter in stable overlay #507

merged 1 commit into from
May 14, 2020

Conversation

saikat-royc
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Enable csi snapshotter sidecar (beta) in stable overlays.
Add necessary csi snapshotter specific manifests to base and update the diffs in the release-staging-head, release-staging-rc, stable, alpha overlays.
Which issue(s) this PR fixes:

Fixes #457

Special notes for your reviewer:
This is part 1 of the Pull Request.
Subsequent PR will include documentation changes and bump the pd csi driver version.
Does this PR introduce a user-facing change?:

Enable csi snapshotter side car (beta) for PD CSI driver.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @saikat-royc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2020
@k8s-ci-robot k8s-ci-robot requested review from jingxu97 and saad-ali May 13, 2020 06:21
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2020
@saikat-royc
Copy link
Member Author

/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 13, 2020 06:21
@saikat-royc saikat-royc force-pushed the enable-csi-snapshotter-stable branch from 4342b8f to 969074a Compare May 13, 2020 06:26
@msau42
Copy link
Contributor

msau42 commented May 13, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2020
msau42
msau42 reviewed May 13, 2020
View reviewed changes
deploy/kubernetes/base/controller.yaml Outdated
@@ -48,6 +48,15 @@ spec:
volumeMounts:
- name: socket-dir
mountPath: /csi
- name: csi-snapshotter
imagePullPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the imagePullPolicy here. Usually it's unnecessary to have to always pull a new image, unless you're reusing the same tag, which is generally only applicable to dev scenarios.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

deploy/kubernetes/overlays/alpha/kustomization.yaml Outdated
patches:
- controller_add_snapshotter.yaml
images:
- name: gke.gcr.io/csi-snapshotter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove support for the alpha snapshot feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please clarify @msau42 ? Do you mean use beta snapshot side car here for the alpha overlay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@saikat-royc
Copy link
Member Author

/retest

@msau42
Copy link
Contributor

msau42 commented May 13, 2020

Can you also update the README, as well as the examples?

@msau42
Copy link
Contributor

msau42 commented May 13, 2020

(and user guides)

@saikat-royc
Copy link
Member Author

Can you also update the README, as well as the examples?

Sure. Will do as a separate PR to update all necessary docs.

@saikat-royc saikat-royc force-pushed the enable-csi-snapshotter-stable branch from 969074a to 09d40f3 Compare May 13, 2020 21:13
@saikat-royc
Copy link
Member Author

/retest

@msau42
Copy link
Contributor

msau42 commented May 13, 2020

/lgtm
/approve

snapshot tests were run and passed in the pull job

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@saikat-royc
Copy link
Member Author

/retest

2 similar comments
@saikat-royc
Copy link
Member Author

/retest

@saikat-royc
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit b581803 into kubernetes-sigs:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deployments to include new snapshot controller (for v1beta1 APIs), start running tests, and update docs
3 participants
@saikat-royc @k8s-ci-robot @msau42