Skip to content

Provide optional flags to run PD CSI driver snapshot tests #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2020
Merged

Provide optional flags to run PD CSI driver snapshot tests #505

merged 1 commit into from
May 12, 2020

Conversation

saikat-royc
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Summary of changes:

  1. Added a snapshot-class option to pass VolumeSnapshotClass.
  2. Added a default VolumeSnapshotClass definition, which uses PD CSI as a snapshot driver.
  3. Remove “Feature:” tag from skipString, since snapshot tests have a [Feature:VolumeSnapshotDataSource] tag.
  4. Prevent snapshot tests from running pre 1.17 kubernetes version.
  5. Allow snapshot tests run only in release-staging-head and release-staging-rc overlays, since the snapshotter is not yet enabled in stable.

Which issue(s) this PR fixes:

Fixes #457

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enable PD CSI snapshot tests for release-staging-head and release-staging-rc

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2020
@k8s-ci-robot k8s-ci-robot requested review from davidz627 and verult May 11, 2020 21:05
@k8s-ci-robot
Copy link
Contributor

Hi @saikat-royc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2020
@saikat-royc
Copy link
Member Author

/cc @msau42

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2020
@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 11, 2020 21:05
@saikat-royc
Copy link
Member Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@saikat-royc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42
Copy link
Contributor

msau42 commented May 11, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2020
msau42
msau42 reviewed May 11, 2020
View reviewed changes
test/k8s-integration/main.go Outdated
@@ -333,6 +333,8 @@ func generateTestSkip(normalizedVersion string) string {
// bug-fix introduced in 1.17
// (https://github.com/kubernetes/kubernetes/pull/81163)
skipString = skipString + "|volumeMode\\sshould\\snot\\smount\\s/\\smap\\sunused\\svolumes\\sin\\sa\\spod"
// Skip Snapshot tests pre 1.17
skipString = skipString + "|External.*Storage.*snapshot"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the "External Storage" part?

Copy link
Member Author

@saikat-royc saikat-royc May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the integration tests initiated from this PD CSI repo is passed in as --storage.testdriver and test/run-k8s-integration.sh uses External.Storage focus, we can simply skip snapshot tests using "snapshot"

@saikat-royc saikat-royc force-pushed the external-snapshotter-integration-tests branch from 7a01896 to fe230b4 Compare May 11, 2020 21:53
@msau42
Copy link
Contributor

msau42 commented May 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saikat-royc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@saikat-royc
Copy link
Member Author

/retest

1 similar comment
@saikat-royc
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2e2a158 into kubernetes-sigs:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@verult verult Awaiting requested review from verult

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deployments to include new snapshot controller (for v1beta1 APIs), start running tests, and update docs
3 participants
@saikat-royc @k8s-ci-robot @msau42