Added unit tests for identity server, fixed small spec inconsistency #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
davidz627
force-pushed
the
feature/identityTests
branch
from
f5e0821 to
eee158c
Compare
msau42
reviewed
Jul 3, 2018
| @@ -52,6 +57,7 @@ func (gceDriver *GCEDriver) SetupGCEDriver(cloudProvider gce.GCECompute, mounter | |||
|
|
|||
| gceDriver.name = name | |||
| gceDriver.nodeID = nodeID | |||
| gceDriver.vendorVersion = vendorVersion | |||
There was a problem hiding this comment.
There's a place down in the cloud provider file where you're putting the driver name/version in the string. You may want to plumb this down to there too
k8s-ci-robot
added
size/L
|
/hold Going to implement better compile time versioning injection |
k8s-ci-robot
added
the
do-not-merge/hold
davidz627
force-pushed
the
feature/identityTests
branch
from
48bcfcd to
f558d59
Compare
|
/hold cancel Added version compile time injection |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@msau42 ready for review |
|
/lgtm |
davidz627
force-pushed
the
feature/identityTests
branch
from
f558d59 to
dd7e5c0
Compare
k8s-ci-robot
added
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
davidz627
force-pushed
the
feature/identityTests
branch
from
dd7e5c0 to
f5d59ac
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
|
@msau42 for re-lgtm, sorry |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
bertinatto
pushed a commit
to bertinatto/gcp-compute-persistent-disk-csi-driver
that referenced
this pull request
Nov 30, 2023
STOR-1392: Rebase to v1.12.2 for OCP 4.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests. In the process found out the GetPluginInfo was missing vendor version so it was fixed to return the vendor version now.
vendor version is: The version of the driver as declared by the vendor (driver author)
so it makes sense to be a const and not a flag
/assign @msau42
Fixes: #47