Qualify external-attacher 2.1.1 in RC staging; enable Prometheus metrics in attacher, provisioner, and resizer #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
size/S
msau42
reviewed
Feb 18, 2020
| @@ -0,0 +1,11 @@ | |||
| - op: add | |||
| path: /spec/template/spec/containers/0/args/- | |||
There was a problem hiding this comment.
Can we add comments saying which containers these applies to?
| @@ -0,0 +1,11 @@ | |||
| - op: add | |||
| path: /spec/template/spec/containers/0/args/- | |||
| value: "--metrics-address=:8080" | |||
There was a problem hiding this comment.
Will all of the sidecars listening on 8080 conflict? Also will probably cause issues with hostNetwork as well
|
Addressed comments! |
msau42
reviewed
Feb 19, 2020
| version: v1 | ||
| kind: StatefulSet | ||
| name: csi-gce-pd-controller | ||
| path: provisioner_metric_args.yaml |
There was a problem hiding this comment.
a more fitting file name could be "enable_sidecar_metrics"
verult
changed the title
…ics in provisioner, attacher, and resizer
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, verult The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it: Qualify external-attacher 2.1.1 in RC staging; enable Prometheus metrics in attacher, provisioner, and resizer
/assign @msau42