-
Notifications
You must be signed in to change notification settings - Fork 159
Implement ValidateVolumeCapabilities and refactor parameter handling for more comprehensive validation of existing disks in all cloud calls #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much of this is going to conflict with #415? Should we try getting that one in first?
} | ||
switch strings.ToLower(k) { | ||
case ParameterKeyType: | ||
if v != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be considered an error if a user specified a key without a value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in-tree PD just treats that case as the default. I tried setting type: ""
and it just created a pd-standard
without complaining - I think we should be backwards compatible here
#415 seems to have stalled and already has conflicts |
@msau42 added unit tests, PTAL |
…for more comprehensive validation of existing disks in all cloud calls
/lgtm |
TODO:
/kind cleanup
/kind feature
/assign @msau42 @misterikkit
Partially does #384 (Still need to do
Node
side validation in a seperate PR)Fixes #162