Fix Resize call to return size in Gi as expected when disk is already the request size or larger #462
Conversation
… the request size or larger
k8s-ci-robot
added
kind/failing-test
|
@davidz627: GitHub didn't allow me to assign the following users: gnufied. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
|
Also the error logs were totally incorrect so I just fixed that as I was going |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| if sizeGb >= requestGb { | ||
| return requestBytes, nil | ||
| return sizeGb, nil |
There was a problem hiding this comment.
@gnufied also identified this as one of the problematic driver responses to resize. We should be returning the actual size, not the requested size.
There was a problem hiding this comment.
Nm it's too early in the morning to read properly :-)
There was a problem hiding this comment.
Can we add a unit test for this case that verifies we return actual size instead of request?
There was a problem hiding this comment.
it's really hard to unit test this package right now as there was no easy way to fake out the actual cloud provider layer. So this "is" the cloud provider layer that I hacked together that we use as an interface to fake out. Suggestions welcome. It's in the backlog to switch over to the autogenerated cloud provider client layer that we switched over to in Kubernetes a while back - that provided the ability to fake out calls and unit test these types of things effectively.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
/kind bug
/kind failing-test
/assign @msau42 @gnufied
Fixes #433