Skip to content

Update k8s.io/utils version for format error message fix #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2020

Conversation

davidz627
Copy link
Contributor

Updated to new version of k8s.io/utils which returns the actual error message from the mkfs command. For read-only volumes this helps user understand what the problem is.

E0124 19:18:36.772218       1 utils.go:58] /csi.v1.Node/NodeStageVolume returned with error: rpc error: code = Internal desc = Failed to format and mount device from ("/dev/disk/by-id/google-disk2") to ("/var/lib/kubelet/plugins/kubernetes.io/csi/pv/podpv/globalmount") with fstype ("ext4") and options ([]): format of disk "/dev/disk/by-id/google-disk2" failed: type:("ext4") target:("/var/lib/kubelet/plugins/kubernetes.io/csi/pv/podpv/globalmount") options:(["defaults"]) errcode:(exit status 1) output:(mke2fs 1.44.5 (15-Dec-2018)
/dev/disk/by-id/google-disk2: Read-only file system while setting up superblock

/kind cleanup
Fixes #296

Mounting an unformatted volume with an fstype as read-only now throws a more descriptive error

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2020
@davidz627 davidz627 changed the title Update k8s.io/utils version and run Update k8s.io/utils version for format error message fix Jan 24, 2020
@msau42
Copy link
Contributor

msau42 commented Jan 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2020
@davidz627
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit dd14907 into kubernetes-sigs:master Jan 25, 2020
@davidz627 davidz627 deleted the fix/ro branch January 27, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Driver doesn't throw a useful error with unformatted readonly disks
3 participants