Skip to content

Update volume limits for new machine types: https://cloud.google.com/compute/docs/machine-types #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

Update volume limits for new machine types: https://cloud.google.com/compute/docs/machine-types #455

merged 1 commit into from
Jan 24, 2020

Conversation

davidz627
Copy link
Contributor

/kind bug
/kind cleanup

Fixes #445

/assign @msau42

Set volume limits to 15 only for machine-types: "f1-micro", "g1-small", "e2-micro", "e2-small", "e2-medium". Limit is 127 for all others

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2020
@davidz627
Copy link
Contributor Author

/retest

yoesmat
yoesmat reviewed Jan 22, 2020
View reviewed changes
pkg/gce-pd-csi-driver/node.go
} else {
volumeLimits = volumeLimitSmall

smallMachineTypes := []string{"f1-micro", "g1-small", "e2-micro", "e2-small", "e2-medium"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using a map of machine types to volume size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are only two volume size limits and only a very small subset are "small" so that is probably not necessary, see here for an interesting comparison of lookup times between slices and maps: https://www.darkcoding.net/software/go-slice-search-vs-map-lookup/ (breakeven point around 5 items).

The thing I want to avoid is a map for small things with all the value being smallValue and then "everything not in the map is big". Or else I would have to be exhaustive with the map which is error prone and repetitive

@msau42
Copy link
Contributor

msau42 commented Jan 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 74549d5 into kubernetes-sigs:master Jan 24, 2020
@davidz627 davidz627 deleted the fix/newTypes branch January 24, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoesmat yoesmat yoesmat left review comments

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@verult verult Awaiting requested review from verult

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support attach limits for new machine types
4 participants
@davidz627 @k8s-ci-robot @msau42 @yoesmat