Break k/k dependency by migrating util/mount and copying resizefs. Re-enable sanity testing. Fix deps. #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
davidz627
force-pushed
the
fix/newMounter
branch
from
9d8c411 to
68f68e1
Compare
|
Some of the resize e2e tests are failing because of permissions things. I will look into it tomorrow |
davidz627
force-pushed
the
fix/newMounter
branch
from
68f68e1 to
c718c3f
Compare
…s.io/csi-test. Migrate from k/k/util/mnt to k/utils/mnt and copy resizefs impl breaking k/k dependency :) Fix sanity testing and node unit tests.
davidz627
force-pushed
the
fix/newMounter
branch
from
c718c3f to
5b61a25
Compare
|
@misterikkit @msau42 should be ready for review now :) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly bump versions of k8s.io/apimachinery, k8s.io/utils, csi.k8s.io/csi-test. Migrate from k/k/util/mnt to k/utils/mnt and copy resizefs impl breaking k/k dependency :) Fix sanity testing and node unit tests.
/kind cleanup
/assign @misterikkit @msau42
Fixes #452