-
Notifications
You must be signed in to change notification settings - Fork 159
Add psp to allow deploying csi-gce-pd-node #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add psp to allow deploying csi-gce-pd-node #448
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ffilippopoulos! |
Hi @ffilippopoulos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cncf cla signed |
/ok-to-test |
/lgtm |
/approve cancel |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ffilippopoulos The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oops. Jumped the gun there. |
@davidz627 thank you very much for looking into this. I updated the release note in the PR description. |
/cc @ffilippopoulos does the gce.privileged PSP satisfy your requirements? https://github.com/kubernetes/kubernetes/blob/3491129d348eb6fb5e4274112df5a946ded740af/cluster/gce/addons/podsecuritypolicies/privileged.yaml#L4 AFAIU it should be installed by default if PSP is enabled. |
@verult as far as I can see that policy doesn't specify any host paths that are allowed to mount and is a bit wide regarding the allowed host ports to bind. We prefer to use psps that fit the deployment precisely as best practice and not pass out more privileges than we should. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
In case of a cluster with
PodSecurityPolicies
enabled using kustomization base will not be enough to deploycsi-gce-pd-node
and we have to also create the psp resource with local manifests. This PR is adding the missing psp that we used to deploycsi-gce-pd-node
.Since
podsecuritypolicy
is a kube resource available to all clusters regardless if the feature is enabled or not this will not impact users that do not use policies.Does this PR introduce a user-facing change?:
Users that patch psps locally will have to drop their patches and use the base, others shall not be affected.