Skip to content

Add psp to allow deploying csi-gce-pd-node #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

ffilippopoulos
Copy link
Contributor

@ffilippopoulos ffilippopoulos commented Jan 8, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:

In case of a cluster with PodSecurityPolicies enabled using kustomization base will not be enough to deploy csi-gce-pd-node and we have to also create the psp resource with local manifests. This PR is adding the missing psp that we used to deploy csi-gce-pd-node.
Since podsecuritypolicy is a kube resource available to all clusters regardless if the feature is enabled or not this will not impact users that do not use policies.

Does this PR introduce a user-facing change?:
Users that patch psps locally will have to drop their patches and use the base, others shall not be affected.

Adding `PodSecurityPoliciy` to allow `csi-gce-pd-node` in clusters with policies enabled.
IF LOCAL PSP MANIFEST PATCH IS USED PLEASE BEWARE THAT YOU WILL NEED TO DELETE LOCAL CHANGES AND USE THE UPSTREAM

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ffilippopoulos!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ffilippopoulos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2020
@ffilippopoulos
Copy link
Contributor Author

cncf cla signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 8, 2020
@davidz627
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2020
@davidz627
Copy link
Contributor

/lgtm
/approve
Thanks @ffilippopoulos!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2020
@davidz627
Copy link
Contributor

/approve cancel

@k8s-ci-robot k8s-ci-robot merged commit 58e28ac into kubernetes-sigs:master Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffilippopoulos
To complete the pull request process, please assign davidz627
You can assign the PR to them by writing /assign @davidz627 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@davidz627
Copy link
Contributor

oops. Jumped the gun there.
@ffilippopoulos the only thing I wanted to ask of you is could you improve the release note to have a description of what this change is adding. If user action is required please note that in a separate line in all caps along with the precondition and action required

@ffilippopoulos
Copy link
Contributor Author

@davidz627 thank you very much for looking into this. I updated the release note in the PR description.

@ffilippopoulos ffilippopoulos deleted the add-node-psp branch January 13, 2020 16:42
@verult
Copy link
Contributor

verult commented Mar 12, 2020

/cc

@ffilippopoulos does the gce.privileged PSP satisfy your requirements? https://github.com/kubernetes/kubernetes/blob/3491129d348eb6fb5e4274112df5a946ded740af/cluster/gce/addons/podsecuritypolicies/privileged.yaml#L4

AFAIU it should be installed by default if PSP is enabled.

@ffilippopoulos
Copy link
Contributor Author

@verult as far as I can see that policy doesn't specify any host paths that are allowed to mount and is a bit wide regarding the allowed host ports to bind. We prefer to use psps that fit the deployment precisely as best practice and not pass out more privileges than we should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants