Use canary quay images to test latest sidecars #444
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| @@ -7,14 +7,14 @@ images: | |||
| newName: gcr.io/gke-release-staging/gcp-compute-persistent-disk-csi-driver | |||
| newTag: "latest" | |||
There was a problem hiding this comment.
hmmm this is a problem too isn't it?
There was a problem hiding this comment.
maybe we need to enable GCE_PD_DO_DRIVER_BUILD?
There was a problem hiding this comment.
yeah this tag is really old now - from sep 9.
Enabling the build flag isn't so easy - then we also need to add logic to go and parse this kustomization file and swap out "latest" for whatever the new build tag is... Though that logic already exists for the pre-submits so maybe its not so hard to port over to this file too. Want to do that or follow up later with it?
We should really figure out what to do about the test tag versions
There was a problem hiding this comment.
From a quick glance, I think our k8s-integration.go should be able to handle substituting the image properly when we set the flag. It takes both overlay and registry as an argument. So no extra changes needed here.
There was a problem hiding this comment.
ack. are you adding that change to this PR?
There was a problem hiding this comment.
no, setting DO_DRIVER_BUILD is not in this repo. I'll send out a separate pr for that
|
/assign @davidz627 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Use the public canary quay images until we redo our CI pipeline for latest testing
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: