Added a waitforattach verification at the end of ControllerPublishVolume #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
davidz627
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
davidz627
force-pushed
the
fix/VerifyAttach
branch
from
8cfe048 to
cf2f3c4
Compare
davidz627
changed the title
k8s-ci-robot
added
size/M
|
/assign @msau42 |
msau42
reviewed
Jul 3, 2018
| @@ -255,6 +255,7 @@ func TestCreateVolumeArguments(t *testing.T) { | |||
| } | |||
|
|
|||
| // Test volume already exists | |||
|
|
|||
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #43
There is an issue where Attach and the Attach Op can return success/DONE but the volume may not actually be attached to the instance. This PR adds an extra check where we poll the disk object for the instances it is attached to before returning success.
/assign @msau42